chore: clean-up#13373
Merged
Merged
Conversation
The `y0` output in the view-offset example was rendered without `.0` decimal suffixes, deviating from the convention used throughout the rest of the file and the sibling `cxpy` REPL docs.
The `y0` output in the view-offset example was rendered without `.0` decimal suffixes, deviating from the convention used throughout the rest of the file and the sibling `zxpy` REPL docs.
…ill-equal`
The `searchElement` JSDoc, C doc-comment, and README C API parameter descriptions all duplicated the wording used for `alpha` ("scalar constant") or capitalized "Element" mid-sentence. Aligns each with the correct "search element" description used in the `.d.ts` and the README's JavaScript API section.
…n/loss-functions` The README's C API section referenced enum identifiers (`STDLIB_ML_SGD_CLASSIFICATION_*`) that do not exist in the header — the header declares `STDLIB_ML_BASE_SGD_CLASSIFICATION_LOSS_FUNCTIONS` — so the documented C usage example would not compile. Also corrects the `loss functions.h` filename typo in the JS enum comment and adds missing array-index spacing in the test.
…ipt declarations Adds imports and interface members for the `cxmy`, `zxmy`, and `dfillEqual` packages, which are registered on the runtime namespace but were missing from the aggregate `.d.ts`.
Planeshifter
changed the title
develop commits
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
The `.0` decimal suffixes added in 86040fd and 5affd15 pushed the `y0` output past the 80-character REPL line-length lint rule (the values `-15/80/148/232` don't fit under 80 chars once suffixed, unlike the smaller values in the sibling `cxpy`/`zxpy` docs). Reverts to the integer formatting the original commits used.
7 tasks
kgryte
reviewed
Jul 8, 2026
Member
There was a problem hiding this comment.
@Planeshifter These sorts of changes should not be considered "fixes". We have automated workflows for this. This sort of proposed change just adds noise. In short, tell your bot to stay in its lane.
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Jul 8, 2026
kgryte
added
Documentation
kgryte
changed the title
develop commits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains follow-up fixes for commits merged to
developbetween 2026-07-07 14:20 PDT (b5b7b4c) and 2026-07-08 01:31 PDT (bb93e56). Findings were surfaced by an automated multi-agent review of the window's union diff, then filtered to keep only high-signal, unambiguous defects (typos, broken doc identifiers, style-guide violations, and a demonstrable declarations gap).Fixes, grouped by package:
searchElementparam docs mislabeled as "scalar constant"/"search Element" acrossblas/ext/base/dfill-equal(lib/dfill_equal.js,lib/dfill_equal.native.js,lib/ndarray.js,lib/ndarray.native.js,src/main.c,README.md), normalizing to "search element" to matchdocs/types/index.d.ts; copy-paste leftover from ad0783b.ml/base/sgd-classification/loss-functions(3148fe6), the C API docs inREADME.mdreferenceSTDLIB_ML_SGD_CLASSIFICATION_LOSS_FUNCTIONS/STDLIB_ML_SGD_CLASSIFICATION_HINGE, but the header declaresSTDLIB_ML_BASE_SGD_CLASSIFICATION_LOSS_FUNCTIONS/STDLIB_ML_BASE_SGD_CLASSIFICATION_HINGE(missing_BASE_), so the documented usage example doesn't compile; fixed to matchinclude/stdlib/ml/base/sgd-classification/loss_functions.h. Also fixed a stray filename typo (loss functions.h→loss_functions.h) inlib/enum.jsand spacing (obj[ o[i] ]→obj[ o[ i ] ]) intest/test.jsto match house style.cxmy,zxmy, anddfillEqualimports and interface members inlib/node_modules/@stdlib/blas/ext/base/docs/types/index.d.ts, mirroring the siblingcxpy/dfill/zxpyblocks; these three landed on the runtime namespace via 5402a8a but were never added to the declarations file, which 044b270 last touched for other packages.Related Issues
No.
Questions
No.
Other
Validation. The multi-agent review comprised: (1) two style-guide compliance passes (one over the new BLAS/ML packages, one over the docs / lint / refactor sweeps), each comparing every touched file against an established sibling of similar shape; (2) two independent bug hunts over the diff-only surface. Findings surviving cross-agent verification and diff re-check were kept; the rest were dropped as either subjective or out-of-scope.
Deliberately excluded from this PR:
.0decimal suffixes to they0REPL output inblas/ext/base/{cxmy,zxmy}/docs/repl.txt— initially applied for consistency with siblingcxpy/zxpydocs, then reverted because the resulting line exceeds the 80-character REPL line-length lint rule (the larger absolute values in thecxmy/zxmyexample don't fit once suffixed). The original integer formatting was a deliberate choice by the package authors to satisfy the same rule.isnan-guard ordering inconsistency across thestats/base/distsrefactor (b5b7b4c) — both orderings are functionally equivalent and the JS style guide does not prescribe one. Left to a follow-up if maintainers want to normalize.09d16f18"returns → e.g., returns" wording fix intoregexp/basename/README.md— the README example is guarded by an explicit "Assuming a POSIX platform..." comment and the original lint sweep did not touch READMEs.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was assembled by an automated Claude Code review routine. The routine enumerated commits merged to
developin the preceding 24 hours, fanned out to independent reviewer subagents (two for stdlib style-guide compliance, two for bug hunting), merged and filtered the findings to a high-signal set, applied the fixes grouped by package, and drafted this body. A maintainer should audit each commit before promoting from draft.